Refactor Spoutcraft client for multiloader support#5
Open
noramibu wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the client code and assets are in
commonnow, and Fabric & NeoForge only keep loader-specific files, on their own subfolders ^^Also while adding support for NeoForge, I removed Fabric API requirement to make mod more dependency free, and if needed it can support other mod loaders more easily in future, without depending to Forgified Fabric API or any other dependencies.
In NeoForge, I used network-thread payload handling on NeoForge because custom content needs to be registered before chunk packets decode custom block IDs which may (will) cause crashes ^^
Also did some other changes such as:
Builds can be find at
/spoutcraft-mod/neoforge/build/libs/and/spoutcraft-mod/fabric/build/libs/Additionally mod works fine on Quilt because it no longer depends to Fabric API