Skip to content

Conversation

@Lego-archer-elf
Copy link
Contributor

@Lego-archer-elf Lego-archer-elf commented Sep 24, 2025

Updated old recipe and feature explanations.
Added new recipe and feature explanations.
Removed removed recipe and feature explanations.

Summary by CodeRabbit

  • Documentation
    • Features: Cleaned up loot table notes; expanded Warp details (3 named, 16 colored, 12 numbered; command book-managed); added Baby Animals mechanics (“Forever Young/Old” naming with glow feedback); dragon defeat now names the killer; first-diamond anti-cheat warning and x-ray warning note; added screenshot placeholder.
    • Recipes: Reorganized headings/sections; updated Dispenser section; clarified Bone Block phrasing; added 6-Sided Logs rebalance; enabled mushrooms in Fermented Spider Eyes; reduced Smithing Template cost (7→3 diamonds); revised Experience Bottle ingredients; expanded Sponge Duplication to living coral variants; added reversible Unpackable Clay; refreshed images.

@coderabbitai
Copy link

coderabbitai bot commented Sep 24, 2025

Walkthrough

Documentation updates to Craftify features and recipes: revised loot table notes, expanded warp details, added baby animal naming mechanics, adjusted server messages and anti-cheat notes; reorganized recipes content and headings, updated multiple recipe rules (logs, smithing templates, experience bottles, sponge duplication), and added new subsections.

Changes

Cohort / File(s) Summary
Features doc updates
docs/products/craftify/features.md
Removed specific loot table bullets; rewrote and expanded Warp section (targets, management notes); added Baby Animals mechanics; updated dragon defeat announcement to include killer; added anti-cheat warning on first diamond and x-ray note; inserted screenshot placeholder.
Recipes doc updates
docs/products/craftify/recipes.md
Updated metadata description; restructured headings; replaced/renamed sections (e.g., Dispenser); clarified and updated multiple recipes (6-sided logs yield, fermented spider eyes, smithing templates cost 3 diamonds, experience bottle ingredients, sponge duplication allowing living coral variants, unpackable clay); updated image paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my whiskers at pages renewed,
Warps mapped neatly, recipes reviewed.
Baby mobs stay spry—names cast the spell,
Diamonds warn cheaters, as dragons fell.
Logs give more, bottles now glow—
A rabbit approves with a happy “hello!”
(_/)> hop!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly states the primary intent of the changeset — updating content to match the current datapack version — which aligns with the PR objectives and the documented changes to Craftify features and recipes. It is a short, single sentence that reflects the main change and is directly related to the modifications in the diff. Although it could be slightly more specific about which docs or version, it accurately summarizes the PR's purpose.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch craftify_v6.2_docs

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (6)
docs/products/craftify/recipes.md (3)

25-29: Add alt text to dispenser image.
Improves accessibility and fixes MD045 for this image.

Apply:

-![](../../../src/img/products/craftify/crafting/dispenser.png)
+![Dispenser bulk crafting recipe](../../../src/img/products/craftify/crafting/dispenser.png)

78-83: Fix item name, material spelling, and remove placeholder.
Use the official item name, correct “sculk” spelling, and drop the placeholder line.

Apply:

-To craft an Experience Bottle, you will need 1 quartz, 1 glowstone dust, 3 sculk, and a water bottle.
+To craft a Bottle o' Enchanting, you will need 1 quartz, 1 glowstone dust, 3 sculk, and a water bottle.
@@
-*Insert alternate updated recipe with Skulk*

Also update the section header (outside this hunk) for consistency:

## Bottle o' Enchanting

117-123: Typos and clarity in Sponge Duplication and Clay sections.
Correct “interchangable”, lower-case “fans”, and tighten wording. Add image alt text.

Apply:

-When sponge (wet or dry) is combined with coral blocks and corals, 4 sponges can be crafted. Coral or Coral Fans are interchangable, and any colour of Coral can be used, but all must be living.
+When a sponge (wet or dry) is combined with coral blocks and coral or coral fans, 4 sponges can be crafted. Coral types are interchangeable, any colour may be used, but all coral must be living.
@@
-![](../../../src/img/products/craftify/crafting/sponge.png)
+![Sponge duplication recipe](../../../src/img/products/craftify/crafting/sponge.png)
docs/products/craftify/features.md (3)

15-18: Tighten wording; fix capitalization.
Avoid generic “online games” phrasing and capitalize “Minecraft”.

Apply:

-This feature is particularly useful in games with large maps or those that require exploration, as it allows players to discover new areas without having to travel long distances on foot. 
+This is particularly useful on large worlds that encourage exploration, letting players discover new areas without long overland travel.
@@
-In addition to the Wild warp system, this offers targeted warps that allow players to travel to pre-set locations. Targeted warps include 3 named points (Spawn, Shop, Community), 16 coloured warps (The minecraft colour set), and 12 numbered warps (1 to 12). All except the numbered warps are created and managed using a command book.
+In addition to the Wild warp, targeted warps allow travel to pre-set locations. Targeted warps include 3 named points (Spawn, Shop, Community), 16 coloured warps (the Minecraft colour set), and 12 numbered warps (1 to 12). All except the numbered warps are created and managed using a command book.

Consider standardizing “color/colour” across docs; pick one and apply consistently.


29-29: Grammar: “broadcasted” → “broadcast”.

Apply:

-* When the dragon is defeated, an announcement is broadcasted to the server naming the player who killed the dragon.
+* When the dragon is defeated, an announcement is broadcast to the server naming the player who killed the dragon.

28-34: Replace screenshot placeholders

Replace the four "*insert screenshot..." lines in docs/products/craftify/features.md with real images (Markdown image syntax) including descriptive alt text and optional captions, or remove those placeholder lines.

Locations: docs/products/craftify/features.md — lines 28, 30, 32, 34

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 733934e and 35bbeef.

📒 Files selected for processing (2)
  • docs/products/craftify/features.md (1 hunks)
  • docs/products/craftify/recipes.md (4 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/products/craftify/recipes.md

13-13: Images should have alternate text (alt text)

(MD045, no-alt-text)


17-17: Images should have alternate text (alt text)

(MD045, no-alt-text)


23-23: Images should have alternate text (alt text)

(MD045, no-alt-text)


28-28: Images should have alternate text (alt text)

(MD045, no-alt-text)


119-119: Images should have alternate text (alt text)

(MD045, no-alt-text)

🔇 Additional comments (6)
docs/products/craftify/recipes.md (4)

3-3: Good metadata update.
Description now matches the page’s purpose.


8-11: Section releveling LGTM.
Promoting Bulk Crafting to H2 and nesting is clearer.


20-22: Phrasing improvement LGTM.
Concise and accurate.


43-45: Confirm v6.2 smithing template costs.
Verify all template duplication costs are 3 diamonds (including Netherite Upgrade, if applicable).

If needed, I can cross-check the datapack sources and update the doc.

docs/products/craftify/features.md (2)

3-3: Good metadata.
Accurate, concise description.


21-25: Clarify case sensitivity for trigger names.
Are “Forever Young” / “Forever Old” case-sensitive and language-dependent? Add a note if so.

I can add a one-line note once confirmed.

### Chests
Crafting a chest with logs directly results in four chests, simplifying the process of creating numerous chests without the need to convert logs into planks first.

![](../../../src/img/products/craftify/crafting/bulk_chest.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

Add missing alt text to images (MD045).
These images lack alt text.

Apply:

-![](../../../src/img/products/craftify/crafting/bulk_chest.png)
+![Bulk chest crafting recipe](../../../src/img/products/craftify/crafting/bulk_chest.png)
@@
-![](../../../src/img/products/craftify/crafting/bulk_chest_random.png)
+![Mixed logs chest crafting variants](../../../src/img/products/craftify/crafting/bulk_chest_random.png)
@@
-![](../../../src/img/products/craftify/crafting/bone_block.png)
+![Bone block crafting recipe](../../../src/img/products/craftify/crafting/bone_block.png)

Run to find missing/typo’d images and remaining no-alt-text:

Also applies to: 17-17, 23-23


🏁 Script executed:

#!/bin/bash
# List image refs lacking alt text
rg -nP '!\[\]\(' docs/products/craftify

# Verify referenced images exist
rg -nP '!\[.*\]\(([^)]+)\)' docs/products/craftify | \
  gawk -F'\\(|\\)' '{print $2}' | sort -u | \
  while read -r p; do
    if [ -f "$p" ]; then echo "OK   $p"; else echo "MISS $p"; fi
  done

Length of output: 3930


Add missing alt text (MD045) and restore missing images in docs/products/craftify/recipes.md

Replace every empty-image reference in docs/products/craftify/recipes.md (occurrences at lines 13, 17, 23, 28, 36, 41, 49, 54, 56, 58, 60, 65, 75, 80, 87, 92, 99, 104, 109, 114, 119, 128, 131) with descriptive alt text, e.g.:
Bulk chest crafting recipe

The following referenced image files are missing — add them to src/img/products/craftify/crafting/ or correct the paths:

  • ../../../src/img/products/craftify/crafting/bee_nest.png
  • ../../../src/img/products/craftify/crafting/blackstone.png
  • ../../../src/img/products/craftify/crafting/bone_block.png
  • ../../../src/img/products/craftify/crafting/bulk_chest.png
  • ../../../src/img/products/craftify/crafting/bulk_chest_random.png
  • ../../../src/img/products/craftify/crafting/chainmail_boots.png
  • ../../../src/img/products/craftify/crafting/chainmail_chestplate.png
  • ../../../src/img/products/craftify/crafting/chainmail_helmet.png
  • ../../../src/img/products/craftify/crafting/chainmail_leggings.png
  • ../../../src/img/products/craftify/crafting/dispenser.png
  • ../../../src/img/products/craftify/crafting/dragon_egg.png
  • ../../../src/img/products/craftify/crafting/elytra.png
  • ../../../src/img/products/craftify/crafting/experience_bottle.png
  • ../../../src/img/products/craftify/crafting/fermented_spider_eye.png
  • ../../../src/img/products/craftify/crafting/flesh_to_leather.png
  • ../../../src/img/products/craftify/crafting/gravel.png
  • ../../../src/img/products/craftify/crafting/guilded_blackstone.png
  • ../../../src/img/products/craftify/crafting/noch_apple.png
  • ../../../src/img/products/craftify/crafting/sponge.png
  • ../../../src/img/products/craftify/crafting/trident.png
  • ../../../src/img/products/craftify/crafting/unpack_blue_ice.png
  • ../../../src/img/products/craftify/crafting/unpack_packed_ice.png
  • ../../../src/img/products/craftify/crafting/wood_rebalance.png
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

13-13: Images should have alternate text (alt text)

(MD045, no-alt-text)

🤖 Prompt for AI Agents
In docs/products/craftify/recipes.md around lines 13 to 131, multiple image
references are empty (MD045) and many referenced image files are missing;
replace each empty image reference at the listed lines with a descriptive alt
text (e.g. "Bulk chest crafting recipe" for the bulk_chest.png line) and ensure
each image tag uses a clear descriptive alt string, and then restore the missing
image files by adding the listed PNGs to src/img/products/craftify/crafting/ (or
correct their paths if they live elsewhere): bee_nest.png, blackstone.png,
bone_block.png, bulk_chest.png, bulk_chest_random.png, chainmail_boots.png,
chainmail_chestplate.png, chainmail_helmet.png, chainmail_leggings.png,
dispenser.png, dragon_egg.png, elytra.png, experience_bottle.png,
fermented_spider_eye.png, flesh_to_leather.png, gravel.png,
guilded_blackstone.png, noch_apple.png, sponge.png, trident.png,
unpack_blue_ice.png, unpack_packed_ice.png, wood_rebalance.png; verify each
image path is correct and committed so the markdown renders and MD045 is
resolved.

@benrobson benrobson merged commit 59bed9c into master Sep 24, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants