fix: make rerun optional for router#46
Open
JudeDavis1 wants to merge 3 commits into
Open
Conversation
Author
|
@Mohamed-512 could we merge this if everything's good? Need this urgently for a project. |
|
Is this still being maintained? Looks like this PR is from a while ago |
Owner
|
There's been new changes and this PR has build files committed. Please fix and update the commit. Or close if your need has been resolved in the recent package update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue where StreamLit errors about how rerunning is a no-op, and it shows it forcibly on the frontend. To fix this, I want to make the
experimental_set_query_paramscall optional in theroute()method optional.Note: this will not change the default routing behavior, it will just give users an option to suppress that no-op error.