Harden Forknote2 blockchain_branch depth parsing to prevent allocation DoS#26
Merged
MoneroOcean merged 1 commit intoMay 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tx_extra_merge_mining_tag.depthdirectly to sizebytecoin_block.blockchain_branch, enabling a malicious block blob to force an enormous allocation and crash the process.Description
static constexpr size_t MAX_BYTECOIN_BLOCKCHAIN_BRANCH_DEPTH = 64and returnfalsewhenmm_tag.depthexceeds this value before callingPREPARE_CUSTOM_VECTOR_SERIALIZATIONin theblockchain_branchdeserialization path insrc/cryptonote_basic/cryptonote_basic.h.Testing
npm testlocally, but the run could not complete due to network/npm registry access restrictions (HTTP 403 while fetching dependencybech32), so the automated test suite did not finish successfully.Codex Task