Bounds-check mm_tag.depth before allocating parent blockchain_branch for v2/v3 blocks#31
Closed
MoneroOcean wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
parent_blockforBLOCK_MAJOR_VERSION_2/BLOCK_MAJOR_VERSION_3made an untrustedtx_extramerge-miningdepthreachable from callers and it was used to resizeblockchain_branchwithout bounds, allowing OOM or exception aborts.mm_tag.depthfrom driving an uncheckedstd::vector::resizewhile preserving valid deserialization behavior.Description
src/cryptonote_basic/cryptonote_basic.hthat checksmm_tag.depthagainstar.remaining_bytes() / sizeof(crypto::hash)before callingPREPARE_CUSTOM_VECTOR_SERIALIZATION.!typename Archive<W>::is_saving()) and returnsfalsefor inputs that claim more branch entries than remain in the serialized stream.b.blockchain_branchwhen the claimed depth cannot be satisfied by the input bytes.Testing
npm testin this environment, which failed before running tests due to dependency fetch error (403 Forbidden - GET https://registry.npmjs.org/bech32) so test suite could not be executed.Codex Task