Repository navigation
Conversation
For DDL/DML we could simply have an empty list of descriptions but it seems that this does not adheres to the PEP-0249 which requires description attribute to be `None` in case of an operations which does not return any rows
DDL/DML mapi messages do not include a query id. If we want to have an empty result set in the result sets set then we need to support `None` query_ids
Contributor
Author
|
not sure why the TLS support test is failing or how to fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements proposal of #129
one thing that still bothers me is the interface of
cursor._store_result()and particularly theupdate_existingbool parameter. I understand that this is used for the caching functionality (see the call atcursor._populate_cache()) but I'm not sure if we will ever encounter a_store_result()call with ablockthat contains an empty result set (due to a DDL/DML statement) together with aupdate_existing=True. I think not but not 100% sure. Any input's welcome 🙂