Adds symmetrical movement sub-flag.#38
Merged
Merged
Conversation
adds handling for optional -s flag with move.
adds actual logic for mirrored subtitle movements
Owner
|
Mostly works for me, please read my comment so that i can merge it :) |
Contributor
Author
|
You mean the comment in #37? I don't see any reviews requested. |
Owner
Just to be clear, i don't know how to use github that well, so maybe i did something wrong, but i mean this |
Contributor
Author
|
Yeah, for some reason it's not showing up for me. Thanks for the image though, I'll work on it later today. |
Contributor
Author
|
There, changes made per request. --symmetrical is now a proper argument... although it only applies to the movement argument for now. |
Owner
|
Thank you for your work :3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this, I'm not a very competent coder.
This sub-flag
-sfor the movement command reverses the movement direction of subtitles if they're above the midway point on the screen, like such:closes #37