Library/Camera: Remove normalizeUp from LookAtCamera - #1337
Open
german77 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
status:waiting for review
german77
changed the title
normalizeUp from LookAtCamera
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slight temporary regression. normalizeUp is called every time setUp is called and is required for some functions to match in open-ead/sead#213
Currently the sead PR breaks compilation in SMO and I want to fully pass the check since that PR is quite big and is important to verify that no unwanted regressions are introduced. Once 213 is merged the functions will be matching again.
This change is
Report for 1.0 (b64cbfb - 896b3e5)
📉 Matched code: 15.49% (-0.01%, -1392 bytes)
🥀 2 broken matches
Library/Play/Camera/CameraVerticalAbsorberal::CameraVerticalAbsorber::update()Library/Camera/CameraPoseral::CameraPoser::makeLookAtCameraPrev(sead::LookAtCamera*) const