add CoCo for all import types

cdlang/src/main/java/de/monticore/cd4codebasis/cocos/CD4CodeBasisCoCos.java

@@ -5,8 +5,11 @@
 import de.monticore.cd4codebasis._cocos.CD4CodeBasisCoCoChecker;
 import de.monticore.cd4codebasis.cocos.ebnf.CD4CodeEnumConstantParameterMatchConstructorArguments;
 import de.monticore.cd4codebasis.cocos.ebnf.CDMethodSignatureParameterNamesUnique;
+import de.monticore.cdbasis._cocos.CDBasisASTCDTargetImportStatementCoCo;
+import de.monticore.cdbasis.cocos.CDOnlyResolvableImportStatements;
 import de.monticore.cdbasis.cocos.ConstructorNameEqualsClassNameCoCo;
 import de.monticore.types.check.AbstractDerive;
+import de.monticore.types.mcbasictypes._cocos.MCBasicTypesASTMCImportStatementCoCo;
 
 public class CD4CodeBasisCoCos extends CoCoParent<CD4CodeBasisCoCoChecker> {
 
@@ -28,6 +31,16 @@ protected void addCheckerForAllCoCos(CD4CodeBasisCoCoChecker checker) {
     addCheckerForMcg2EbnfCoCos(checker);
   }
 
+  @Override
+  protected void addMcgCoCos(CD4CodeBasisCoCoChecker checker) {
+    super.addMcgCoCos(checker);
+
+    // CDImport Statements
+    CDOnlyResolvableImportStatements resolvableImports = new CDOnlyResolvableImportStatements();
+    checker.addCoCo((CDBasisASTCDTargetImportStatementCoCo) resolvableImports);
+    checker.addCoCo((MCBasicTypesASTMCImportStatementCoCo) resolvableImports);
+  }
+
   @Override
   protected void addEbnfCoCos(CD4CodeBasisCoCoChecker checker) {
     super.addEbnfCoCos(checker);

cdlang/src/main/java/de/monticore/cdbasis/cocos/CDOnlyResolvableImportStatements.java

@@ -0,0 +1,38 @@
+/* (c) https://github.com/MontiCore/monticore */
+package de.monticore.cdbasis.cocos;
+
+import de.monticore.cdbasis.CDBasisMill;
+import de.monticore.cdbasis._ast.ASTCDTargetImportStatement;
+import de.monticore.cdbasis._cocos.CDBasisASTCDTargetImportStatementCoCo;
+import de.monticore.types.mcbasictypes._ast.ASTMCImportStatement;
+import de.monticore.types.mcbasictypes._cocos.MCBasicTypesASTMCImportStatementCoCo;
+import de.se_rwth.commons.logging.Log;
+
+public class CDOnlyResolvableImportStatements implements CDBasisASTCDTargetImportStatementCoCo,
+    MCBasicTypesASTMCImportStatementCoCo {
+
+  @Override
+  public void check(ASTCDTargetImportStatement node) {
+    if (node.isStar())
+      return; // TODO: Star imports can not be checked at the moment
+    String qName = node.getMCQualifiedName().getQName();
+    if (CDBasisMill.globalScope().resolveTypeMany(qName).isEmpty()) {
+      Log.warn("0xCDC40: Could not resolve target import ` " + qName
+          + "` within the input models or symbol path.", node.get_SourcePositionStart(), node
+              .get_SourcePositionEnd());
+    }
+  }
+
+  @Override
+  public void check(ASTMCImportStatement node) {
+    if (node.isStar())
+      return; // TODO: Star imports can not be checked at the moment
+    String qName = node.getMCQualifiedName().getQName();
+    if (CDBasisMill.globalScope().resolveTypeMany(qName).isEmpty()) {
+      Log.error("0xCDC41: Could not resolve import `" + qName
+          + "` within the input models or symbol path.", node.get_SourcePositionStart(), node
+              .get_SourcePositionEnd());
+    }
+  }
+
+}

cdlang/src/test/java/de/monticore/testcdbasis/cocos/CDOnlyResolvableImportStatementsTest.java

@@ -0,0 +1,53 @@
+/* (c) https://github.com/MontiCore/monticore */
+package de.monticore.testcdbasis.cocos;
+
+import de.monticore.cdbasis._cocos.CDBasisASTCDTargetImportStatementCoCo;
+import de.monticore.cdbasis.cocos.CDOnlyResolvableImportStatements;
+import de.monticore.cdbasis._ast.ASTCDCompilationUnit;
+import de.monticore.runtime.junit.MCAssertions;
+import de.monticore.testcdbasis.CDBasisTestBasis;
+import de.monticore.types.mcbasictypes._cocos.MCBasicTypesASTMCImportStatementCoCo;
+import de.se_rwth.commons.logging.Log;
+import org.junit.jupiter.api.Test;
+import java.io.IOException;
+import java.util.Optional;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class CDOnlyResolvableImportStatementsTest extends CDBasisTestBasis {
+
+  @Test
+  public void testInvalidTargetImportStatement() throws IOException {
+    CDOnlyResolvableImportStatements coCo = new CDOnlyResolvableImportStatements();
+    coCoChecker.addCoCo((CDBasisASTCDTargetImportStatementCoCo) coCo);
+    coCoChecker.addCoCo((MCBasicTypesASTMCImportStatementCoCo) coCo);
+    final Optional<ASTCDCompilationUnit> optAST = p.parse(getFilePath(
+        "cdbasis/cocos/CDUnresolvableTargetImportStatementsInvalid.cd"));
+    assertTrue(optAST.isPresent());
+    final ASTCDCompilationUnit ast = optAST.get();
+    Log.getFindings().clear();
+    coCoChecker.checkAll(ast);
+    MCAssertions.assertHasFindingsStartingWith("0xCDC40");
+    assertEquals(1, Log.getFindings().size());
+  }
+
+  @Test
+  public void testInvalidMCImportStatement() throws IOException {
+    CDOnlyResolvableImportStatements coCo = new CDOnlyResolvableImportStatements();
+    coCoChecker.addCoCo((CDBasisASTCDTargetImportStatementCoCo) coCo);
+    coCoChecker.addCoCo((MCBasicTypesASTMCImportStatementCoCo) coCo);
+    final Optional<ASTCDCompilationUnit> optAST = p.parse(getFilePath(
+        "cdbasis/cocos/CDUnresolvableMCImportStatementsInvalid.cd"));
+    assertTrue(optAST.isPresent());
+    final ASTCDCompilationUnit ast = optAST.get();
+    Log.getFindings().clear();
+    coCoChecker.checkAll(ast);
+    MCAssertions.assertHasFindingsStartingWith("0xCDC41");
+    assertEquals(1, Log.getFindings().size());
+    assertTrue(Log.getFindings().get(0).getMsg().startsWith("0xCDC41"));
+  }
+
+  @Override
+  public void after() {}
+
+}

cdlang/src/test/resources/de/monticore/cdbasis/cocos/CDUnresolvableMCImportStatementsInvalid.cd

@@ -0,0 +1,15 @@
+/* (c) https://github.com/MontiCore/monticore */
+import this.path.doesnt.Exist;
+
+classdiagram CDUnresolvableImportStatementsInvalid {
+
+  class A {
+    int number = 1;
+  }
+
+  class B extends A{
+    derived int number = 5;
+  }
+
+}
+

cdlang/src/test/resources/de/monticore/cdbasis/cocos/CDUnresolvableTargetImportStatementsInvalid.cd

@@ -0,0 +1,15 @@
+/* (c) https://github.com/MontiCore/monticore */
+targetimport this.path.doesnt.Exist;
+
+classdiagram CDUnresolvableTargetImportStatementsInvalid {
+
+  class A {
+    int number = 1;
+  }
+
+  class B extends A{
+    derived int number = 5;
+  }
+
+}
+

cdlang/src/test/resources/de/monticore/cdbasis/cocos/Valid.cd

@@ -1,4 +1,5 @@
 /* (c) https://github.com/MontiCore/monticore */
+import java.util.List;
 
 classdiagram Valid {
 

cdtool/src/test/java/de/monticore/ExampleCommandTest.java

@@ -175,8 +175,12 @@ public void testStoringSymbolsPerPathsExample1() {
     tool.run(new String[] { "-i", fileName });
 
     // Then
-    assertEquals(3, Log.getFindingsCount(), "Actual findings: " + Log.getFindings().toString());
+    assertEquals(4, Log.getFindingsCount(), "Actual findings: " + Log.getFindings().toString());
     assertEquals("0xA0324 Cannot find symbol Address", Log.getFindings().get(0).getMsg());
+    assertEquals(
+        "0xCDC41: Could not resolve import `MyAddress.Address` within the input models or symbol path.",
+        Log.getFindings().get(3).getMsg());
+
     Log.clearFindings();
   }