Skip to content

#467 Test, der zeigt, dass Typvariablen in den serialisierten List-Datentypen der KerML fehlen #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathias-pfeiffer merged 9 commits into from
Oct 7, 2026
Merged

#467 Test, der zeigt, dass Typvariablen in den serialisierten List-Datentypen der KerML fehlen #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3fd3229
#467 add testcase that fails
Oct 3, 2026
7af3077
#467 added CollectionsListGenericTypeFromSymFile
Oct 4, 2026
0087823
#467 minifix
Oct 5, 2026
e745a16
#467 remove extra test
Oct 5, 2026
92fd449
#467 removed comment
Oct 5, 2026
66a9973
#467 removed codeblock
Oct 5, 2026
ca7e811
Apply suggestion from @mathias-pfeiffer
hewes2 Oct 5, 2026
67f0951
Apply suggestion from @mathias-pfeiffer
hewes2 Oct 5, 2026
b4bcaff
#467 changed test
Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions language/src/main/grammars/de/monticore/lang/SysMLv2.mc4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ grammar SysMLv2 extends SysMLExpressions,
SysMLQualifiedName extends MCQualifiedName =
Name (("::" | ".") Name)* ;

SysMLBasicGenericType extends MCBasicGenericType =
Name (("." | "::") Name)* "<" (MCTypeArgument || ",")* ">";

astrule SysMLQualifiedName =
method public List<String> getPartsList() {
return getNameList();
Expand Down
4 changes: 2 additions & 2 deletions language/src/main/java/de/monticore/lang/sysmlv2/SysMLv2Mill.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static void prepareGlobalScope() {
SysMLv2Tool.loadStreamSymbolsFromJar();
}

protected static void loadScalarValuesFromSym() {
public static void loadScalarValuesFromSym() {
getMill()._loadScalarValuesFromSym();
}

Expand Down Expand Up @@ -133,7 +133,7 @@ public static void addKermlCollectionsTypes() {
getMill()._addCollectionsPackage();
}

protected static void loadCollectionValuesFromSym() {
public static void loadCollectionValuesFromSym() {
getMill()._loadCollectionFromSym();
}

Expand Down
19 changes: 19 additions & 0 deletions language/src/test/java/symboltable/StandardLibraryImportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import de.monticore.lang.sysmlv2.SysMLv2Tool;
import de.monticore.lang.sysmlv2._symboltable.ISysMLv2Scope;
import de.monticore.symbols.basicsymbols._symboltable.TypeSymbol;
import de.monticore.types3.TypeCheck3;
import de.se_rwth.commons.logging.Log;
import de.se_rwth.commons.logging.LogStub;
import org.junit.jupiter.api.BeforeAll;
Expand All @@ -18,6 +19,7 @@
import java.io.IOException;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;

public class StandardLibraryImportTest {
public static SysMLv2Tool tool;
Expand Down Expand Up @@ -145,6 +147,23 @@ public void testCollectionsListResolving(String model) throws IOException {
assertThat(Log.getFindings()).isEmpty();
}

@Test
public void testCollectionsListGenericTypeFromSymFile() throws IOException {
LogStub.init();
var tool = new SysMLv2Tool();
tool.init();
// We clear the globalScope to load the KerMLSym
tool.getGlobalScope().clear();

SysMLv2Mill.loadScalarValuesFromSym();
SysMLv2Mill.loadCollectionValuesFromSym();
assertThat(Log.getFindings()).isEmpty();

var ast = SysMLv2Mill.parser()
.parse_StringMCType("Collections::List<ScalarValues::Boolean>").get();
assertThrows(NullPointerException.class, () -> TypeCheck3.symTypeFromAST(ast));
}

@Test
public void testStatesImport() throws IOException {
var model = " private import States::*;"+
Expand Down
Loading