forked from wled/WLED
-
-
Notifications
You must be signed in to change notification settings - Fork 121
Merge version scripts and change nightly tag from -mdev to -nightly #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
mdev
Choose a base branch
from
copilot/merge-version-scripts
base: mdev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d7cf202
Initial plan
Copilot 00aaae3
Merge version scripts and update nightly tag from -mdev to -nightly
Copilot 4e48a31
Refactor set_version.py for better code organization
Copilot 9c881e0
Improve version tag handling for multi-hyphen versions
Copilot 16d3d10
Revert package.json to keep original -mdev tag
Copilot 7c68b20
Remove redundant -mdev check as suggested by @softhack007
Copilot 74aab68
Make environment variable check more robust as suggested by @softhack007
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,27 @@ | ||
| Import('env') | ||
| Import('env') # PlatformIO-specific import | ||
| import json | ||
| import os | ||
| from datetime import datetime, timezone | ||
|
|
||
| PACKAGE_FILE = "package.json" | ||
|
|
||
| with open(PACKAGE_FILE, "r") as package: | ||
| version = json.load(package)["version"] | ||
| env.Append(BUILD_FLAGS=[f"-DWLED_VERSION={version}"]) | ||
|
|
||
| # Handle nightly build | ||
| if os.environ.get('WLED_NIGHTLY_BUILD', '').lower() in ('true', '1', 'yes'): | ||
| # VERSION format: yymmddb (b = build number, 0 for nightly) | ||
| version_code = datetime.now(timezone.utc).strftime("%y%m%d") + "0" | ||
| env.Append(BUILD_FLAGS=[f"-DWLED_BUILD_VERSION={version_code}"]) | ||
| print(f"Nightly build: Setting VERSION to {version_code}") | ||
|
|
||
| # Update version tag: replace existing tag with "-nightly" or append "-nightly" if no tag | ||
| if "-" in version: | ||
| # Replace any existing tag with -nightly (handles multiple hyphens correctly) | ||
| version = version.rsplit("-", 1)[0] + "-nightly" | ||
| else: | ||
| # No tag present, append -nightly | ||
| version = version + "-nightly" | ||
| print(f"Nightly build: Using version string {version}") | ||
|
|
||
| env.Append(BUILD_FLAGS=[f"-DWLED_VERSION={version}"]) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.