fix Keep season context when playing specials displayed inline in a seaon - #1074
Merged
RadicalMuffinMan merged 1 commit intoAug 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
A special with
AirsBefore/AirsAftermetadata is displayed inside a regularseason once the library has
DisplaySpecialsWithinSeasonsenabled, but the itemstill carries Specials as its own
SeasonId. Opening such a special from aseason reloaded the detail screen against Specials, and playing it queued the
Specials season rather than the run that was on screen.
This carries the browsed season through navigation and playback so an inlined
special stays in the season that actually lists it.
Related Issues
Type of Change
Changes Made
seasonContextquery parameter, so thedetail screen loads the list the viewer came from and falls back to the item's
own season when that list does not contain it.
special's own
SeasonId.item, so the rollover after an inlined special continues into the correct season.
order; sorting by season number would drag a special to the front of the run it
was placed in.
of stopping after the single item.
lib/util/season_queue_context.dartconsolidates season/queue resolutionthat was previously duplicated in
playback_module.dart(net −90 lines there).Platform
Testing
Unit tests cover the season/queue resolution logic; the app was built and
launched on macOS to confirm the branch compiles and runs.
Test Steps
DisplaySpecialsWithinSeasonson a TV library whose series has aspecial with
AirsBefore/AirsAftermetadata.pulled to the front of the season).
Specials.
next season.
as part of Specials.
Screenshots (if applicable)
N/A — no visual changes; behaviour only.
Checklist