feat-ui - SPOILERZONE: The PR - #1088
Open
mattsigal wants to merge 1 commit into
Open
Conversation
…gles - Reorganize Details Screen settings panel into Display, Media Details and Spoilers, and Recommendations sections - Reorganize Home Screen settings panel into Home Row Display, Continue Watching and Next Up, Media Details and Spoilers, and Home Row Sections - Add preference toggles: hideDetailsMediaDescription, detailUseSeriesThumbnails, and hideHomeMediaDescription - Implement series landscape thumbnail resolution fallback for Classic details screen components (_EpisodeThumbnail, _EpisodeListCardState, DetailNextUpCard, DetailEpisodeCard, DetailChaptersRow) - Guard overview description text in Classic and Modern detail views and Home screen hero / info overlay with media description toggles - Update synced_fields, search index, and localization files
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This PR covers hiding spoilers from the UI in terms of both images (e.g., episode thumbnails) and text (e.g., plot descriptions). Reorganized the Details Screen and Home Screen settings panels under unified section layouts, added 3 new spoiler protection preferences (
hideDetailsMediaDescription,detailUseSeriesThumbnails,hideHomeMediaDescription), implemented series landscape thumbnail resolution fallbacks across all Classic details page components, and added a dedicated Continue Watching & Next Up settings section.Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
hideDetailsMediaDescription,detailUseSeriesThumbnails,hideHomeMediaDescription) in user_preferences.dart, registered keys in synced_fields.dart, updated synced_fields_test.dart, and added search entries in settings_search_index.dart._resolveSeriesLandscapeThumbnailUrlin item_detail_screen.dart to resolve 16:9 landscape series artwork (Thumbtag ->parentThumb->Backdroptag ->seriesPrimaryfallback) without passing mismatched episode tags, applying series landscape thumbnail fallback to _EpisodeThumbnail, _EpisodeListCardState, DetailNextUpCard, DetailEpisodeCard, and DetailChaptersRow.flutter gen-l10n.Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
The Spoilers
The Settings - Details Page (Modern)
The Settings - Details Page (Classic)
The Settings - Home Rows (Modern)
Homescreen, No Description Text
Spoiler-less Modern Details Page - MOVIE
Spoiler-less Modern Details Page - TV SHOW
Spoiler-less Classic Details Page - MOVIE
Spoiler-less Classic Details Page - TV SHOW
Checklist