Skip to content

bugfix-ratings - Fix Rotten Tomatoes critics rating mismatch from MDBList - #202

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
mattsigal:bugfix/ratings-mdblist-matching
Jul 20, 2026
Merged

bugfix-ratings - Fix Rotten Tomatoes critics rating mismatch from MDBList#202
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
mattsigal:bugfix/ratings-mdblist-matching

Conversation

@mattsigal

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Fixes the Rotten Tomatoes critics score mismatch from MDBList by translating "tomatoes" back to the MDBList cache key "tomato" in the server plugin.

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Related to #

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • API / endpoint change
  • Settings schema change
  • Documentation update
  • Build/CI change
  • Other (describe):

Area

  • Settings sync / profiles
  • Admin defaults / config page
  • Ratings (MDBList / TMDB)
  • Notifications / Push (FCM / relay)
  • Seerr integration
  • Games / Emulators
  • Custom home rows
  • Web Client (Go to Moonfin-Core repo)
  • Other / shared

Changes Made

List the key changes included in this PR.

  • MdbListController.cs: Updated FilterAndOrderRatings to look up the "tomato" cache key when "tomatoes" is requested from the Jellyfin server backend.
  • RatingsService.cs: Updated lookup logic to map "tomatoes" to "tomato" when querying from the Emby server backend cache.

Client Impact

Does this need matching changes in a client repo (Core, Smart-TV, Roku)?

Compatibility

  • Change to the settings profile is additive only, no renamed or removed properties
  • New properties use the same type the client sends (a client bool maps to bool?, an int to int?)
  • Migration added for any renamed or removed settings
  • Older clients still work, unknown fields are ignored and no keys were removed

Testing

Describe how this change was tested.

  • Built the plugin and deployed to a Jellyfin server
  • Verified against a live client (which one: Windows Client)
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Rebuild the Moonbase plugin and deploy it to Jellyfin.
  2. Query server ratings for an item with Rotten Tomatoes ratings and confirm "tomato" is returned correctly when client requests "tomatoes".

Screenshots (if applicable)

Include config page screenshots or request/response samples where relevant.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced
  • Any new setting keys match the client-side keys exactly

- Map tomatoes to tomato for MdbList cache lookup in Jellyfin backend.
- Map tomatoes to tomato for MdbList cache lookup in Emby backend.
@github-actions

Copy link
Copy Markdown

Build Successful

The plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.

Property Value
Commit e023b08
Workflow Build #224

@RadicalMuffinMan
RadicalMuffinMan merged commit ce93e60 into Moonfin-Client:master Jul 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants