Skip to content

Preroll crash #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RadicalMuffinMan merged 2 commits into from
Aug 7, 2026
+3 −3
Merged

Preroll crash #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979143f
fix cinemamode crash and settingssync bool type error
jmawet Aug 7, 2026
dd879ca
Merge branch 'Moonfin-Client:master' into preroll-crash
jmawet Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/manager/QueueManager.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ sub init()
m.queueTypes = []
m.isPlaying = false
' Preroll videos only play if user has cinema mode setting enabled
m.isPrerollActive = m.global.session.user.settings["playback.cinemamode"]
m.isPrerollActive = toBoolean(m.global.session.user.settings["playback.cinemamode"])
m.position = 0
m.preferredAudioTrackIndex = -1
m.preferredAudioTrackName = string.EMPTY
Expand All @@ -36,7 +36,7 @@ sub clear()
m.isPlaying = false
m.queue = []
m.queueTypes = []
m.isPrerollActive = m.global.session.user.settings["playback.cinemamode"]
m.isPrerollActive = toBoolean(m.global.session.user.settings["playback.cinemamode"])
setPosition(0)
if not m.bypassNextPreferredAudioTrackIndexReset
setPreferredAudioTrackIndex(-1)
Expand Down
2 changes: 1 addition & 1 deletion source/utils/settingsSync.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ namespace settingsSync
rokuValue = settingsSync.PluginToRoku(pluginValue, mapping.type)
if not isValid(rokuValue) then continue for

tmpSettings[mapping.rokuKey] = rokuValue
tmpSettings[mapping.rokuKey] = toBoolean(rokuValue)
if not chainLookupReturn(mapping, "skipRegistry", false)
registry_write(mapping.rokuKey, rokuValue, m.global.session.user.id)
end if
Expand Down