Skip to content

fix custom osd progress bar time slots - #209

Open
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:playback-time-settings
Open

fix custom osd progress bar time slots#209
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:playback-time-settings

Conversation

@jmawet

@jmawet jmawet commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Make the osd progress bar time slot settings actually work correctly

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • removed existing videoEndTime and videoRemaining time text labels
  • create new below/above/Left/Right text labels in their proper positions
  • create updateOSDTime helper function to update all 4 text labels based on their settings
  • anytime the existing text labels got updated, replace with a call to updateOSDTime

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Tested all 6 time label options in all 4 slots

Screenshots (if applicable)

Default:

  • Above left: none
  • Below left: elapsed
  • Above right: ends at
  • Below right: total time
image

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant