Skip to content

Library settings fixes #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmawet wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Library settings fixes #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
253ea5a
move merge recents rows setting to correct location
jmawet Aug 8, 2026
c4fb01f
remove unused detailedSubheading setting
jmawet Aug 8, 2026
bdf2564
remove unused detailedSubheading setting
jmawet Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions components/ItemGrid/GridItem.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,6 @@ sub itemContentChanged()
else
end if

useDetailedSubHeadings = get_user_setting_bool("ui.library.useDetailedSubHeadings", true)
if not useDetailedSubHeadings and isValid(itemData.Title)
m.itemText.text = itemData.Title
end if

'If Poster not loaded, ensure "blue box" is shown until loaded
if m.itemPoster.loadStatus <> "ready"
m.posterText.visible = true
Expand Down
4 changes: 2 additions & 2 deletions components/ItemGrid/GridItemMedium.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ sub itemContentChanged()
if isValid(m.topParent.showItemTitles)
if LCase(m.topParent.showItemTitles) = "showalways"
m.title.visible = true
m.itemTextExtra.visible = get_user_setting_bool("ui.library.useDetailedSubHeadings", true)
m.itemTextExtra.visible = true
end if
end if

Expand Down Expand Up @@ -228,7 +228,7 @@ sub focusChanged()
if isValid(m.topParent.showItemTitles)
if LCase(m.topParent.showItemTitles) = "showonhover"
m.title.visible = m.top.itemHasFocus
m.itemTextExtra.visible = m.top.itemHasFocus and get_user_setting_bool("ui.library.useDetailedSubHeadings", true)
m.itemTextExtra.visible = m.top.itemHasFocus
end if
end if
end sub
Expand Down
21 changes: 7 additions & 14 deletions settings/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,6 @@
"type": "bool",
"default": "false"
},
{
"title": "Merge Recently Added Libraries by Type",
"description": "Combine separate libraries of the same type into merged rows on the home page.",
"settingName": "ui.home.mergeRecentRowsByType",
"type": "bool",
"default": "false"
},
{
"title": "Prefer Thumbnails",
"description": "If thumbnails are selected in Home Row Image, show series instead of episode thumbnails.",
Expand Down Expand Up @@ -3118,16 +3111,16 @@
"default": "false"
},
{
"title": "Show Media Details",
"description": "Show details of the selected item at the top of Library pages.",
"settingName": "ui.library.showMediaDetails",
"title": "Merge Recent Rows by Type",
"description": "Combine separate libraries of the same type into merged rows on the home page.",
"settingName": "ui.home.mergeRecentRowsByType",
"type": "bool",
"default": "true"
"default": "false"
},
{
"title": "Use Detailed Sub-Headings",
"description": "Show detailed sub-row metadata on Library pages.",
"settingName": "ui.library.useDetailedSubHeadings",
"title": "Show Media Details",
"description": "Show details of the selected item at the top of Library pages.",
"settingName": "ui.library.showMediaDetails",
"type": "bool",
"default": "true"
},
Expand Down
1 change: 0 additions & 1 deletion source/utils/settingsSync.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ namespace settingsSync
{ pluginKey: "enableMultiServerLibraries", rokuKey: "ui.home.enableMultiServer", type: "bool" },
{ pluginKey: "mergeRecentRowsByType", rokuKey: "ui.home.mergeRecentRowsByType", type: "bool" },
{ pluginKey: "showMediaDetailsOnLibraryPage", rokuKey: "ui.library.showMediaDetails", type: "bool" },
{ pluginKey: "useDetailedSubHeadings", rokuKey: "ui.library.useDetailedSubHeadings", type: "bool" },
{ pluginKey: "hideBackdropsInLibraries", rokuKey: "ui.library.hideBackdrops", type: "bool" },
{ pluginKey: "mediaBarMode", rokuKey: "ui.home.mediaBarMode", type: "direct" },
{ pluginKey: "mediaBarSourceType", rokuKey: "ui.home.mediaBarSourceType", type: "direct" },
Expand Down