Scrollbar selecting fix and game not launching (on huge row libary) fix - #345
Merged
Merged
Conversation
Contributor
Author
|
Build failed because of this: Warning: 82:67 warning Comments inside children section of tag should be placed inside braces react/jsx-no-comment-textnodes. FFS i forgot that js wants this brackets {/* . my god will updated that |
…ng on, plus fixed a bug where game types won't open
Contributor
Author
|
upload_Moonfin for Tizen_2.7.0_20260805013302_298ab9496be8471c9df2f5d6916840f2.log |
✅ Build SuccessfulAll platform builds passed. You can download the test artifacts below.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Games that hade a huge amount of games in a row, could get a selectable scrollbar, wich
A:
Mad scrolling down selecting it bevor scrolling down
B:
Made games not open.
This fixes both. Games info cards launch now and the games are playing now, plus scrolling down selects the next game row instead of the scroll bar
Related Issues
My own. Non on Github
Type of Change
Changes Made
List the key changes included in this PR.
Platform
Testing
Open a Game info card which didn't worked on my huge row library
Test Steps
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
Checklist