test: cover resumed plan state with empty plan - #2284
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e696779287
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
|
|
||
| it.todo('marks resumed plan mode active when the restored plan has no plan data', async () => { | ||
| it('marks resumed plan mode active when the restored plan has no plan data', async () => { |
There was a problem hiding this comment.
This test now runs, but it never creates the advertised “restored plan has no plan data” state: the session setup calls setPlanMode(true), which currently writes a plan_mode.enter record with an id (packages/agent-core/src/agent/plan/index.ts:39), while removeManualPlanIds only removes/edits plan.enter and plan.manual_enter records. As a result, the wire history still contains the normal plan id and this test largely duplicates the preceding resume test instead of covering the legacy/missing-plan-data path; update the fixture to strip plan_mode.enter’s id or seed an actual legacy record before enabling it.
Useful? React with 👍 / 👎.
1 participant
Related Issue
No linked issue.
Problem
The resumed-plan path had no direct regression test for the empty restored plan state.
What changed
Converted the todo into a real test that asserts resumed plan mode stays active and the restored empty plan is still exposed through the public session APIs. No changeset is needed because this is test-only.
Checklist