feat(web): highlight selected settings options with the accent color - #2315
Open
bowenliang123 wants to merge 1 commit into
Open
feat(web): highlight selected settings options with the accent color#2315bowenliang123 wants to merge 1 commit into
bowenliang123 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: c6da1b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ce88e55a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bowenliang123
force-pushed
the
feat/web-settings-accent-highlight
branch
from
July 28, 2026 10:18
2ce88e5 to
c6da1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below.
Problem
In the web settings dialog, selected options in the segmented pickers (theme, accent color, language, default permission) were highlighted with a neutral raised surface, so the selection state did not reflect the accent color the user picked (blue / mono).
What changed
When the Accent color is selected as "Blue",
Before：
After：
tintedvariant to the sharedSegmentedControlcomponent: the selected item uses--color-accent-softbackground +--color-accenttext, matching the settings tab style and following the active accent in both light and dark mode.variant="tinted") to the settings pickers: theme, accent color, and default permission inSettingsDialog, the sharedLanguageSwitcher(also used by the mobile settings sheet), and the theme picker inMobileSettingsSheet.patchon@moonshot-ai/kimi-code(web:entry), since the web app ships bundled in the CLI.Checklist
vue-tsctypecheck and oxlint.)gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update. (Minor visual tweak; no doc impact.)