Fix version check: C23 incompatible with current version check in pyCloudy#15
Open
jchowk wants to merge 3 commits intoMorisset:masterfrom
Open
Fix version check: C23 incompatible with current version check in pyCloudy#15jchowk wants to merge 3 commits intoMorisset:masterfrom
jchowk wants to merge 3 commits intoMorisset:masterfrom
Conversation
The assumed structure of the output files no long allows for the same simple version checking. I've hardwired it to default to C23 when the old approach doesn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of Cloudy (I'm working from C23 grabbed via git) don't code the version number in the *.out files in the same way as prior versions. The git-downloaded version reports the branch and git status as in the following example:
Cloudy (master, 171a3cb5)The fix I've implemented is unsatisfactory, as it doesn't grab the specific version (I'm not quite sure how they encode it yet). Instead it defaults to declaring the major version to 23.
Happy to help track down the versioning logic eventually, but don't have a lot of time for it right now.