refactor(widget): Centralize device name logic and improve widget upd…

[Moustachauve]

…ates

This commit introduces a centralized function for determining a device's display name and refactors widget updates to be more robust and efficient.

• A non-composable getDeviceName utility function has been created to provide a consistent device name (custom name, then original name, then a fallback) for use in widgets and other non-UI contexts.
• The WledWidgetConfigureActivity now uses this new function when creating initial widget data.
• Device name changes now trigger an immediate update on associated widgets, ensuring the new name is reflected without waiting for the next state refresh.
• Deleting a device now correctly clears the data for all its associated widgets, putting them into a re-configurable error state.
• WebSocket and API update logic in WledWidgetManager has been streamlined, now passing the full DeviceWithState or Device object instead of multiple parameters. This allows the manager to consistently use the new getDeviceName function for all updates.

[gemini-code-assist]

Summary of Changes

Hello @Moustachauve, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the consistency and reliability of device name display and widget management within the application. By centralizing the logic for determining a device's display name and streamlining widget update processes, it ensures that widgets accurately reflect device information and respond appropriately to changes in device configuration or deletion.

Highlights

• Centralized Device Naming Logic: A new non-composable getDeviceName utility function has been introduced to provide a consistent method for determining a device's display name (custom name, then original name, then a fallback) across the application, especially for widgets.
• Refactored Widget Update Mechanisms: Widget updates have been streamlined and made more robust. WebsocketClient and WledWidgetManager now pass full DeviceWithState or Device objects, allowing for more consistent and efficient updates.
• Immediate Widget Name Updates: Changes to a device's custom name now trigger an immediate update on associated widgets, ensuring the new name is reflected without delay.
• Improved Device Deletion Handling for Widgets: Deleting a device now correctly clears the data for all its associated widgets, putting them into a re-configurable error state rather than displaying outdated information.
• Consistent Widget Configuration: The WledWidgetConfigureActivity now utilizes the new getDeviceName function when creating initial widget data, ensuring consistency from the start.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a solid refactoring effort that significantly improves the widget functionality. Centralizing the device name logic with the getDeviceName function is a great change for code consistency and maintainability. The widget updates are now more robust, correctly reflecting device name changes and deletions. Streamlining the WledWidgetManager API to use DeviceWithState and Device objects simplifies the code and enhances readability. Overall, these are excellent changes. I have one minor suggestion to ensure I/O operations are explicitly dispatched to a background thread.