Skip to content

Fix iOS 18 cookie loading issue#291

Draft
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
ios18-cookie-fix-14413639943233490940
Draft

Fix iOS 18 cookie loading issue#291
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
ios18-cookie-fix-14413639943233490940

Conversation

@google-labs-jules
Copy link

This change updates GenericCookieHandler.getAllCookies to handle a regression in iOS 18 (Safari) where cookies.getAll returns an empty array if storeId is not explicitly handled or if the default store lookup fails.

The fix involves:

  1. Detecting if the browser is Safari.
  2. Fetching all available cookie stores using browser.cookies.getAllCookieStores().
  3. Iterating through each store and fetching cookies for the current tab's URL with the specific storeId.
  4. Aggregating the results and returning the flattened list of cookies.

This ensures cookies are correctly retrieved on iOS 18 while preserving existing behavior for other browsers.


PR created automatically by Jules for task 14413639943233490940 started by @Moustachauve

@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants