Fix iOS 18 cookie loading issue#291
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change updates
GenericCookieHandler.getAllCookiesto handle a regression in iOS 18 (Safari) wherecookies.getAllreturns an empty array ifstoreIdis not explicitly handled or if the default store lookup fails.The fix involves:
browser.cookies.getAllCookieStores().storeId.This ensures cookies are correctly retrieved on iOS 18 while preserving existing behavior for other browsers.
PR created automatically by Jules for task 14413639943233490940 started by @Moustachauve