Convert the talk screen to NUI#667
Merged
BenjaminAmos merged 1 commit intoMovingBlocks:nui-ported-screensfrom Oct 31, 2022
Merged
Convert the talk screen to NUI#667BenjaminAmos merged 1 commit intoMovingBlocks:nui-ported-screensfrom
BenjaminAmos merged 1 commit intoMovingBlocks:nui-ported-screensfrom
Conversation
This was referenced Sep 28, 2022
Closed
This was referenced Oct 12, 2022
0480e8e to
5f93937
Compare
5f93937 to
3904ff5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request converts the Talk screen to NUI. It should functionally identically to before, although there may be some minor visual differences.
Before
After
Testing
Talkbutton is enabledTalkbuttonBuybutton (or press theBkey)Sellbutton (or press theSkey)Change Shipscreen opens when you click on theChange Shipbutton (or press theCkey)Hire Shipscreen opens when you click on theHirebutton (or press theHkey)Closebutton (or press theEscapekey)Notes
EmptyIfInvisibleContainer,UIBackingBoxandUILabelledIcon) #664 and Convert remaining MainGameScreen visuals to NUI #665.EmptyIfInvisibleContainer,UIBackingBoxandUILabelledIcon) #664 and Convert remaining MainGameScreen visuals to NUI #665 are merged, it might be easier to view the changes made in this pull request by viewing the diff between this and Convert remaining MainGameScreen visuals to NUI #665 at BenjaminAmos/DestinationSol@nui-screen-conversion/main-game-screen...nui-screen-conversion/talk-screen.