Convert MapScreen and WaypointCreationScreen to NUI#669
Merged
BenjaminAmos merged 2 commits intoMovingBlocks:nui-ported-screensfrom Nov 1, 2022
Merged
Conversation
This was referenced Oct 6, 2022
0f8d97d to
ccb2cbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request converts the
MapScreenandWaypointCreationScreenUIs to use NUI.Before
After
Testing
Functional Tests
Map Viewing
Mapbutton or by pressing theTabkey).Zoom Inbutton.Zoom Outbutton.Waypoints
Marker+button is pressed and a position chosen.Cancelshould not place a waypoint.Doneshould place a waypoint.Marker-button and then selecting a waypoint should remove that waypointVisual/Scale Testing
Android builds will not see as significant a difference here because they use automatic screen scaling based on the reported display density.
Notes
EmptyIfInvisibleContainer,UIBackingBoxandUILabelledIcon) #664.