Add regression tests for the password utility - #5
Open
ubf-hunter wants to merge 1 commit into
Open
Conversation
apps/api had no test setup at all. Added jest + ts-jest (matching the NestJS/TypeScript stack already in use) scoped to the API package, and covered the two functions in auth/password.util.ts: - hashPassword: produces a scrypt-tagged hash that never contains the raw password, and salts independently (same password hashes differently each time). - verifyPassword: accepts the correct password, rejects an incorrect one, and rejects malformed/unrecognised hash formats without throwing (an unrelated algorithm tag, a hash missing its parts). Runs via `pnpm test` in apps/api, no PostgreSQL or other external service involved -- password.util.ts is pure crypto (node:crypto scrypt), so nothing here touches Prisma. Closes MrAshki#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/apihad no automated test setup at all. Added jest + ts-jest (matching the NestJS/TypeScript stack already in use) scoped to the API package, and coveredauth/password.util.ts:hashPassword: produces a scrypt-tagged hash that never contains the raw password, and salts independently (the same password hashes differently each time).verifyPassword: accepts the correct password, rejects an incorrect one, and rejects malformed/unrecognised hash formats without throwing (an unrelated algorithm tag, a hash missing its parts).No PostgreSQL or other external service involved —
password.util.tsis pure crypto (node:cryptoscrypt), so nothing here touches Prisma.Closes #3
Test plan
pnpm test(inapps/api) — 6/6 passpnpm typecheck— cleanpnpm lint— clean