fix: prevent completed paths exceeding filesystem limits - #5
Merged
Merged
Conversation
Contributor
Author
|
For context, this was triggered by an anime release with the title english (japanese) - etc — an absolute menace of a release name. Combined with TorBoxarr’s job ID suffix, the resulting completed directory exceeded the filesystem’s per-component limit during finalization. The regression test is based on a similarly long real-world title. |
calmcacil
marked this pull request as ready for review
August 19, 2026 17:55
Owner
|
Thank you, great job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long download display names can produce completed directory names longer than
the filesystem's per-component limit. On Linux filesystems such as ext4, this
can cause finalization to fail when TorBoxarr creates or renames the completed
directory.
Cause
CompletedPathForJobused the sanitized display name and job ID directly as asingle path component without applying a length limit.
Fix
Validation
go test -count=1 ./...go vet ./...git diff --check