Skip to content

Fix GitHub OAuth to send access token via Authorization header #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iceybubble wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix GitHub OAuth to send access token via Authorization header #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 34 additions & 14 deletions src/hello.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,16 +1544,24 @@ hello.api = function() {
}

// Network & Provider
// Define the network that this request is made for
p.network = _this.settings.default_service = p.network || _this.settings.default_service;
var o = _this.services[p.network];

// INVALID
// Is there no service by the given network name?
if (!o) {
reject(error('invalid_network', 'Could not match the service requested: ' + p.network));
return promise;
}
// Define the network that this request is made for
p.network = _this.settings.default_service = p.network || _this.settings.default_service;
var o = _this.services[p.network];

// INVALID
// Is there no service by the given network name?
if (!o) {
reject(error('invalid_network', 'Could not match the service requested: ' + p.network));
return promise;
}

// Force XHR for GitHub so Authorization headers are sent
if (p.network === 'github') {
p.xhr = true;
p.jsonp = false;
p.form = false;
}


// PATH
// As long as the path isn't flagged as unavaiable, e.g. path == false
Expand Down Expand Up @@ -1589,10 +1597,22 @@ hello.api = function() {

// Get the current session
// Append the access_token to the query
p.authResponse = _this.getAuthResponse(p.network);
if (p.authResponse && p.authResponse.access_token) {
p.query.access_token = p.authResponse.access_token;
}
// Get the current session
p.authResponse = _this.getAuthResponse(p.network);

// Append the access_token
if (p.authResponse && p.authResponse.access_token) {

// GitHub requires Authorization header instead of query param
if (p.network === 'github') {
p.headers = p.headers || {};
p.headers.Authorization = 'Bearer ' + p.authResponse.access_token;
} else {
p.query.access_token = p.authResponse.access_token;
}
}



var url = p.path;
var m;
Expand Down