Skip to content

feat(recipe): update search logic to support content locale filtering #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Muetze42 merged 1 commit into from
Feb 21, 2026
Merged

feat(recipe): update search logic to support content locale filtering #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/Http/Controllers/Api/Localized/RecipeController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use App\Http\Resources\Api\RecipeCollection;
use App\Http\Resources\Api\RecipeResource;
use App\Models\Recipe;
use App\Support\Api\ContentLocale;
use Illuminate\Database\Eloquent\Builder;
use Throwable;

Expand All @@ -23,7 +24,7 @@ public function index(RecipeIndexRequest $request): RecipeCollection
->with(['label', 'tags'])
->when($request->filled('search'), function (Builder $query) use ($request): void {
$searchTerm = '%' . $request->string('search') . '%';
$locale = app()->getLocale();
$locale = ContentLocale::get();

$query->where(function (Builder $query) use ($searchTerm, $locale): void {
$query->whereLike('name->' . $locale, $searchTerm)
Expand Down
20 changes: 18 additions & 2 deletions tests/Feature/Http/Controllers/Api/Localized/RecipeControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ public function it_filters_recipes_by_label_id(): void
#[Test]
public function it_filters_recipes_by_search_term(): void
{
// Note: Search uses app locale which is set by ApiLocalizationMiddleware
// The URL prefix de-DE sets the locale to 'de'
Recipe::factory()->for($this->country)->create([
'name' => ['de' => 'Spaghetti Carbonara', 'en' => 'Spaghetti Carbonara'],
]);
Expand All @@ -131,6 +129,24 @@ public function it_filters_recipes_by_search_term(): void
->assertJsonPath('data.0.name', 'Spaghetti Carbonara');
}

#[Test]
public function it_filters_recipes_by_search_term_using_content_locale(): void
{
Recipe::factory()->for($this->country)->create([
'name' => ['de' => 'Hähnchen Teriyaki', 'en' => 'Chicken Teriyaki'],
]);

Recipe::factory()->for($this->country)->create([
'name' => ['de' => 'Pizza Margherita', 'en' => 'Pizza Margherita'],
]);

$response = $this->apiGet('/de-DE/recipes?search=Hähnchen');

$response->assertOk()
->assertJsonCount(1, 'data')
->assertJsonPath('data.0.name', 'Hähnchen Teriyaki');
}

#[Test]
public function it_filters_recipes_by_difficulty(): void
{
Expand Down