453 remove the need for ret in carriers#472
Draft
FJanssen-TNO wants to merge 9 commits intomainfrom
Draft
Conversation
…ctly as a string instead of a integers.
…ers to now use the carrier_id instead of integers
…he same hydraulic network, such that the portname is checked (In replaced by Out) instead of checking the carrier name with _ret
… carrier ids are directly available, also updated all tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the need for _ret in carriers also for 'four port assets' and when using networks with varying temperature.
To apply this, the carrier_id is now passed on directly as one of the parameters. Be aware, this is a string and not a value, therefore it can no longer be extracted using self.parameters() but one has to use self.string_parameters().