Conversation
…into jon-mallen
mallenjon
commented
Jul 1, 2021
mallenjon
commented
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
n_jobsparameter ofsklearn.cluster.KMeanshas since been deprecated in version.23and will later be removed in the new version1.0(a renaming of.25) of their k-means clustering packagesklearn.cluster.KMeans. This simply removes the use of that parameter from our code. Given this, it would be wise to updaterequirements.txtaccordingly. For more information, see the description forrequirements.txtbelow.EMT.txt.scikit-learnrequirement should be greater than or equal to version.23to account for the deprecatedn_jobsparameter insklearn.cluster.KMeans, and to ensure better performance of our clustering using the new version ofsklearn.cluster.KMeansthat has accounted for this change. The requirementsPyYAML,freetype-py,pypng, andumap-learnare now appended to the file.beeling-inputs-boolean.yaml.Note: Comments containing requests for edits that have been responded to with a thumbs up 👍 indicate that an attempt has been made to implement the suggestion and/or it is fixed.