Now is never - #233
Merged
Merged
Now is never#233
Conversation
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="crates/try_v2/src/lib.rs" line_range="11" />
<code_context>
//!
//! - nightly
-//! - `#![feature(never_type)]`
+//! - `#![cfg_attr(unstable_never_type, feature(never_type))]`
//! - `#![feature(try_trait_v2)]`
//! - `#![feature(try_trait_v2_residual)]`
</code_context>
<issue_to_address>
**issue:** The documented `cfg_attr(unstable_never_type, feature(never_type))` does not enable `never_type` for downstream crates, because `unstable_never_type` is emitted by this package's build script only for this package's compilation and is not propagated to consumers. On a pre-stabilization nightly, users copying these examples therefore compile the generated `!` residual types without the required feature and receive a never-type feature-gate error.
**Triggers:** When a consumer uses a pinned nightly older than the stabilization of `never_type` and follows the crate or derive-macro documentation.
**Suggested fix:** Document an unconditional `#![feature(never_type)]` for downstream users, or provide a separately documented consumer-side version/cfg mechanism rather than relying on this crate's private build-script cfg.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: crates/try_v2/src/lib.rs:11
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update tests & examples to work with stabilised-in-nightly never_type