This repository was archived by the owner on Oct 13, 2026. It is now read-only.
Repository navigation
Pull both Ignition versions the labs use (8.3.6 and 8.3.8) - #4
Merged
Merged
Conversation
The labs run on 8.3.6 and 8.3.8, but only 8.3.6 was in COURSE_IMAGES, so everyone downloads the second gateway image on Day 1 — over shared classroom Wi-Fi, behind one NAT, against Docker Hub's per-IP anonymous rate limit. That is the exact failure this pre-pull exists to avoid. Split the two uses apart: IGNITION_IMAGE stays the single image the smoke test and bind-mount check run against, and the new IGNITION_IMAGES holds the full set that gets pulled. Both tags publish amd64 and arm64, so Apple Silicon is unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
COURSE_IMAGESpinned onlyignition:8.3.6, but the labs run both 8.3.6 and 8.3.8. Students therefore pull the second gateway image on Day 1 — over shared classroom Wi-Fi, behind one NAT, against Docker Hub's per-IP anonymous rate limit. That is precisely the failure the pre-pull exists to prevent, as the comment aboveCOURSE_IMAGESsays.Found while reviewing Mustry-Academy/cicd-welcome-package#1, which tells students the preflight pulls both versions. That PR is accurate only once this one lands, so this should merge first.
What
Split the two uses of the pin apart:
IGNITION_IMAGE— unchanged at 8.3.6, still the single image the smoke test and the bind-mount check run against (both only ever need one gateway).IGNITION_IMAGES— new, the full set that gets pulled; feedsCOURSE_IMAGES.README's requirement table updated to list both tags.
Verification
bash -n scripts/preflight.shandshellcheck scripts/*.shclean locally (CI runs both).COURSE_IMAGESexpands to exactly four images in the pull loop, with the smoke-test image still resolving to 8.3.6.docker manifest inspectresolves both tags; each publishesamd64andarm64, so Apple Silicon is unaffected.Not changed: the 20 GB free-disk recommendation still covers the extra image.
🤖 Generated with Claude Code