Fix Windows lockfile contention race - #13
Merged
Merged
Conversation
MuteJester
marked this pull request as ready for review
July 18, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PermissionErrorbut the holder deletes the file before the existence checkRoot cause
Windows can report a sharing violation instead of
FileExistsErrorwhile the owner keeps the lockfile handle open. The owner may then close and unlink the file before the waiting thread checksexists(), causing valid contention to be misclassified as a genuine permission failure.Validation
git diff --check