v1.6.0-rc5#18
Merged
Merged
Conversation
… orden in completed and picked up status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and visibility of invalid or missing cash register selections in the cashier UI, ensuring users are clearly notified if their previously selected register is no longer valid. It also enhances real-time order status updates and refines order cancellation logic.
Cash Register Validation and User Feedback:
Added state and logic to detect if the selected cash register is invalid (e.g., removed from the system), automatically clearing invalid selections, prompting the configuration dialog, and displaying a clear warning message in both desktop and mobile headers and menus. This includes passing a new
cashRegisterInvalidprop through relevant components and updating UI to show an alert when appropriate. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]Updated English and Italian translations to include a message for "Invalid register"/"Cassa non valida" for consistent user feedback. [1] [2]
Order Handling Improvements:
Enhanced the order confirmation process to revalidate the selected cash register against the current list before submitting, preventing orders from being placed with a stale or removed register.
Improved real-time order status updates by handling a new
order-status-updateevent via SSE, ensuring the UI reflects order status changes instantly.Order Cancellation Logic:
CONFIRMED,COMPLETED, orPICKED_UP, and the tooltip and disabled state reflect this broader set of cancellable statuses. [1] [2]