Feat/stats#56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving data consistency and accuracy in API key usage tracking and report generation. The main changes include making database updates for API key usage more robust by using transactions with row-level locking, and adjusting how real-time report data is aggregated and returned.
API Key Usage Consistency:
lastUsedAtinvalidateApiKeymiddleware are now wrapped in a transaction with aSELECT ... FOR UPDATEto ensure row-level locking and prevent race conditions during concurrent updates. [1] [2]Report Generation and Real-Time Data Handling:
realtimeBucket) is now appended only after aggregation, ensuring that only raw reports are aggregated and real-time data is not double-counted. [1] [2] [3]