Replace id with name#38
Merged
Merged
Conversation
…coverage functionality
# Conflicts: # ruff.toml # src/memlord/dao/memory.py # src/memlord/dao/workspace.py # src/memlord/models/memory.py # src/memlord/search.py # src/memlord/tools/get_memory.py # src/memlord/tools/list_memories.py # src/memlord/tools/search_by_tag.py # src/memlord/ui/base.py # src/memlord/ui/data.py # src/memlord/ui/workspaces.py # tests/test_dao.py # tests/test_pipeline.py
MyrikLD
force-pushed
the
replace-id-with-name
branch
from
8b281dc to
2226b12
Compare
# Conflicts: # src/memlord/dao/memory.py # src/memlord/tools/list_memories.py # src/memlord/tools/move.py # src/memlord/tools/search_by_tag.py # src/memlord/ui/base.py # uv.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces numeric id with human-readable name as the primary identifier for MCP tool interactions. IDs remain internal (DB primary key), but all MCP tools now accept and return name instead.
Migration notes
Existing memories without a : separator in content will have name = NULL after migration. The downgrade restores content by prepending name: for all rows that had a name set.