Increase BgCheck_Allocate volume values for faster lookup - Part 2#158
Open
Admentus64 wants to merge 1 commit intomasterfrom
Open
Increase BgCheck_Allocate volume values for faster lookup - Part 2#158Admentus64 wants to merge 1 commit intomasterfrom
Admentus64 wants to merge 1 commit intomasterfrom
Conversation
f54be4b to
c727e4a
Compare
8517a05 to
49fc04a
Compare
49fc04a to
96c8194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #127
Just assign fixed values regardless of any scene. The y subdivision is also raised up to 8. And the reserved RAM is a fixed 0x2A000 now.
Scenes to test:
Check if you fall through the floor in any of the rooms in a scene. If not, you're good. Otherwise we either need to reduce the subdivision values or raise the reserved RAM.
Also test if loading times aren't taking too much of a hit, in which case we need lower subdivision values.