Skip to content

DebugTilesPlugin: Add support for displaying empty tiles bounds #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkjohnson merged 3 commits into from
May 25, 2026
+17 −4
Merged

DebugTilesPlugin: Add support for displaying empty tiles bounds #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63c475a
Cleanup
gkjohnson May 25, 2026
70e6be8
Add debug tiles callback
gkjohnson May 25, 2026
614e9ef
Add empty callback fire
gkjohnson May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/core/renderer/tiles/optimizedTraverseFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,10 +463,6 @@ function toggleTiles( tile, renderer ) {

}

} else {

tile.traversal.active = false;

}

// when loading parent tiles as fallbacks, keep all used tiles downloaded
Expand Down Expand Up @@ -552,6 +548,17 @@ function toggleTiles( tile, renderer ) {

}

} else {

// For non-renderable tiles, notify plugins when the tile becomes or stops being a traversal leaf so we
// can display "empty" tiles in plugins like the DebugTilesPlugin.
setVisible = tile.traversal.isLeaf;
if ( tile.traversal.wasSetVisible !== setVisible ) {

renderer.invokeOnePlugin( plugin => plugin.setEmptyTileVisible && plugin.setEmptyTileVisible( tile, setVisible ) );

}

}

tile.traversal.wasSetActive = setActive;
Expand Down
6 changes: 6 additions & 0 deletions src/three/plugins/DebugTilesPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,12 @@ export class DebugTilesPlugin {

}

setEmptyTileVisible( tile, visible ) {

this._onTileVisibilityChange( tile, visible );

}

_initExtremes() {

if ( ! ( this.tiles && this.tiles.root ) ) {
Expand Down
Loading