Skip to content

CesiumIonPlugin: Remove warnings #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkjohnson merged 1 commit into from
May 25, 2026
Merged

CesiumIonPlugin: Remove warnings #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/plugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,3 @@ export * from '3d-tiles-renderer/core/plugins';

// Export all three.js plugins
export * from '3d-tiles-renderer/three/plugins';

// Override with backward compatible version (no constructor warning)
import { CesiumIonAuthPlugin as CesiumIonAuthPluginDeprecated } from '3d-tiles-renderer/three/plugins';
export class CesiumIonAuthPlugin extends CesiumIonAuthPluginDeprecated {

constructor( options ) {

super( {
...options,
__suppress_warning__: true,
} );

}

}
16 changes: 0 additions & 16 deletions src/three/plugins/CesiumIonAuthPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,12 @@ export class CesiumIonAuthPlugin extends CesiumIonAuthPluginImpl {

if ( type === 'TERRAIN' && tiles.getPluginByName( 'QUANTIZED_MESH_PLUGIN' ) === null ) {

console.warn(
'CesiumIonAuthPlugin: CesiumIonAuthPlugin plugin auto-registration has been deprecated. ' +
'Please implement a custom "assetTypeHandler" for "TERRAIN" using "QuantizedMeshPlugin", instead.'
);
tiles.registerPlugin( new QuantizedMeshPlugin( {
useRecommendedSettings: this.useRecommendedSettings,
} ) );

} else if ( type === 'IMAGERY' && tiles.getPluginByName( 'GENERATED_SURFACE_PLUGIN' ) === null ) {

console.warn(
'CesiumIonAuthPlugin: CesiumIonAuthPlugin plugin auto-registration has been deprecated. ' +
'Please implement a custom "assetTypeHandler" for "IMAGERY" using "GeneratedSurfacePlugin", instead.'
);
const overlay = new TMSTilesOverlay( { url: tiles.rootURL } );
tiles.registerPlugin( new GeneratedSurfacePlugin( { shape: 'ellipsoid', overlay } ) );

Expand All @@ -52,14 +44,6 @@ export class CesiumIonAuthPlugin extends CesiumIonAuthPluginImpl {
...options,
} );

if ( options.__suppress_warning__ ) {

console.warn(
'CesiumIonAuthPlugin: Plugin has been moved to "3d-tiles-renderer/core/plugins".'
);

}

}

}
Loading