Skip to content

fix(stac-api): root path bug and docs update#597

Merged
botanical merged 5 commits into
developfrom
issue-596/multitenancy-docs-update
May 20, 2026
Merged

fix(stac-api): root path bug and docs update#597
botanical merged 5 commits into
developfrom
issue-596/multitenancy-docs-update

Conversation

@botanical
Copy link
Copy Markdown
Member

@botanical botanical commented May 12, 2026

Issue

#596
https://github.com/NASA-IMPACT/veda-architecture/issues/754

What?

  • Updates the docs to include more information about disabling multitenancy features, distinguishing between filtering and authorization
  • Updates TenantExtractionMiddleware logic for root paths with trailing slash (so it skips trailing slash removal for {root_path}/)
  • Adds unit tests for TenantExtractionMiddleware

Tested tenant extraction change in UAH-SIT.

Test setup Result
Envs: STAC_AUTH_PROXY_ENABLED=False, used v14.0.0-rc.16 redirect errors on https://sit.openveda.cloud/api/stac/
Envs: STAC_AUTH_PROXY_ENABLED=False, used this branch's commit SHA redirect errors resolved on https://sit.openveda.cloud/api/stac/

The reason we didn't notice this before is because we never had an instance tested where we had the Tenant Extraction middleware running while Tenant Filtering (AKA stac-auth-proxy) was disabled.

@botanical botanical marked this pull request as ready for review May 13, 2026 23:27
@botanical botanical changed the title feat: multitenancy docs hardening feat: multitenancy hardening May 13, 2026
Comment thread stac_api/runtime/README.md Outdated
Comment thread stac_api/runtime/README.md Outdated
Comment thread stac_api/runtime/README.md Outdated
Co-authored-by: Alexandra Kirk <alexandra@developmentseed.org>
Copy link
Copy Markdown
Collaborator

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve but can we fix the PR conventional commit to reflect that we are also delivering a stac fast api root path bug fix?

@botanical botanical changed the title feat: multitenancy hardening fix(stac-api): root path bu May 20, 2026
@botanical botanical changed the title fix(stac-api): root path bu fix(stac-api): root path bug and docs update May 20, 2026
@botanical botanical merged commit 5bfd7cb into develop May 20, 2026
4 checks passed
@botanical botanical deleted the issue-596/multitenancy-docs-update branch May 20, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants