Skip to content

fix(stac): upgrade stac auth proxy to v1.1.1#605

Open
botanical wants to merge 7 commits into
developfrom
fix/upgrade-stac-auth-proxy-v1.1.1
Open

fix(stac): upgrade stac auth proxy to v1.1.1#605
botanical wants to merge 7 commits into
developfrom
fix/upgrade-stac-auth-proxy-v1.1.1

Conversation

@botanical
Copy link
Copy Markdown
Member

@botanical botanical commented May 27, 2026

Issue

https://github.com/NASA-IMPACT/veda-architecture/issues/762

What?

Upgrade Starlette to 1.0.1 or later. Rebuild and redeploy every container, virtualenv, and bundled artifact that pins or vendors Starlette. Bundled installs are common in LLM tooling; pip list on the host is not enough. Audit images.

Secondary (defense in depth)
Replace request.url and request.url.path with request.scope["path"] in every middleware, dependency, and decorator that makes security decisions. Grep the codebase. This bug class will recur; reading the un-reconstructed value is the durable fix.

Testing

@botanical botanical requested a review from anayeaye May 27, 2026 16:07
@botanical botanical requested a review from ividito May 29, 2026 16:40
Comment on lines +38 to +43
def _request_path(request: Request) -> str:
"""Use request.scope["path"] primarily"""
scope_path = request.scope.get("path")
if isinstance(scope_path, str) and scope_path:
return scope_path
return request.url.path
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope_path will always be a str or None, and so if scope_path will evaluate the same as what we have here. I think instead of calling this function, it would be simpler to use:

path = request.scope.get("path") or request.url.path

or (in common/auth/veda_auth/pep_middleware.py)

path = (request.scope.get("path") or request.url.path).rstrip("/") or "/"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants