fix(stac): upgrade stac auth proxy to v1.1.1#605
Open
botanical wants to merge 7 commits into
Open
Conversation
ividito
reviewed
May 29, 2026
Comment on lines
+38
to
+43
| def _request_path(request: Request) -> str: | ||
| """Use request.scope["path"] primarily""" | ||
| scope_path = request.scope.get("path") | ||
| if isinstance(scope_path, str) and scope_path: | ||
| return scope_path | ||
| return request.url.path |
Collaborator
There was a problem hiding this comment.
scope_path will always be a str or None, and so if scope_path will evaluate the same as what we have here. I think instead of calling this function, it would be simpler to use:
path = request.scope.get("path") or request.url.path
or (in common/auth/veda_auth/pep_middleware.py)
path = (request.scope.get("path") or request.url.path).rstrip("/") or "/"
…om/NASA-IMPACT/veda-backend into fix/upgrade-stac-auth-proxy-v1.1.1
ividito
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://github.com/NASA-IMPACT/veda-architecture/issues/762
What?
request.scope["path"]as recommended by https://www.secwest.net/starletteTesting
POST /collection,DELETE /collection