chore: upgrade Node.js to v24 LTS#1985
Merged
Merged
Conversation
- Bump .nvmrc from 22 to 24 (Node 20 reached end-of-life April 2026; Node 24 is current active LTS) - Bump NODE env var from 22 to 24 in checks.yml; declare NODE env in release.yml (was previously referenced but never set) - Bump package.json engines.node from ">=18.0.0" to ">=20.19.0" to match release-it v20 minimum - Bump release-it from ^17.10.0 to ^20.0.0 (v17 caps at Node 22; v20 adds Node 24 support). Downstream consumers that pin engines.node to 20.x (e.g. veda-config-ghg) were failing to yarn install after bumping to Node 24 because of the transitive release-it engine check. - Upgrade actions/setup-node@v3 → @v4 - Upgrade actions/checkout@v2/v3 → @v4 - Upgrade actions/cache@v3 → @v4 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
release-it@^20 pulls in @types/parse-path@7.1.0 transitively (release-it → git-url-parse → git-up → parse-url → @types/parse-path). v7.1.0 is a deprecated stub with no index.d.ts, which breaks tsc --noEmit with "Cannot find type definition file for 'parse-path'" since @types/* packages are auto-included as implicit type libraries. Pin to 7.0.3 (last version with real type definitions) via yarn resolutions to unblock ts-check on Node 24. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Match .nvmrc and workflow NODE env. The prior >=20.19.0 was overly permissive and sent the wrong signal — this PR forces Node 24, so engines should reflect that. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
slesaad
added a commit
to US-GHG-Center/veda-config-ghg
that referenced
this pull request
Apr 22, 2026
Points to veda-ui commit a84ae2fe (NASA-IMPACT/veda-ui#1985), which: - Bumps release-it ^17 → ^20 (v17 caps Node at 22; v20 supports Node 24) - Pins @types/parse-path to 7.0.3 to unblock ts-check - Tightens engines.node to >=24.0.0 This should unblock the Netlify yarn install, which was failing on release-it@17's engine check against Node 24. This is a temporary pointer to an unmerged branch for CI verification — before merging this PR, bump to an actual released tag on veda-ui main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
dzole0311
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcfrom22to24(Node 24 is current active LTS)NODEenv var from22to24inchecks.ymlNODE: 24at workflow level inrelease.yml(previously referenced via${{ env.NODE }}but never set — pre-existing bug)package.jsonengines.nodefrom">=18.0.0"to">=24.0.0"to match.nvmrcand CI intentrelease-itfrom^17.10.0to^20.0.0— release-it v17 caps Node at 22 (^18.18.0 || ^20.9.0 || ^22.0.0); v20 supports^20.19.0 || ^22.13.0 || >=24.0.0@types/parse-pathto7.0.3via yarnresolutions— release-it@20 transitively pulls in@types/parse-path@7.1.0, which is a deprecated stub with noindex.d.tsand breakstsc --noEmit("Cannot find type definition file for 'parse-path'"). 7.0.3 is the last version with real type definitions.actions/setup-node@v3→@v4,actions/checkout@v2/v3→@v4,actions/cache@v3→@v4Why the release-it bump matters
Downstream consumers that consume veda-ui as a git submodule (e.g.
US-GHG-Center/veda-config-ghg) and pinengines.nodeto Node 24 fail toyarn installbecause the transitive engine check on release-it rejects the runtime. Without this bump, Node 24 cannot propagate downstream.Risk
.release-it.jsconfig uses standard hooks + git/npm/github plugin APIs, which are stable across this range. The local custom plugin at./recommended-bump/index.mjsshould continue to load via the standard plugin API. The Monday scheduled release will be the first real exercise; if it breaks, revert just the release-it line.Test plan
yarn ts-checkpasses locally on Node 24 (after the @types/parse-path pin)Checksworkflow passes in CI (prep, lint, ts-check, test, playwright)yarn installsucceeds on Node 24release.ymlwith--debugflag (if available) to dry-run release-it v20veda-config-ghgcan bump the submodule pointer and yarn install cleanly on Node 24🤖 Generated with Claude Code