(#78) Elasticsearch 8 update#82
Draft
blairlearn wants to merge 1 commit intodevelopfrom
Draft
Conversation
blairlearn
force-pushed
the
ticket/78-es8
branch
from
9d25ece to
ff57678
Compare
blairlearn
force-pushed
the
ticket/78-es8
branch
2 times, most recently
from
402a473 to
02af708
Compare
1. Elasticsearch client migration
- Replace NEST / Elasticsearch.Net with Elastic.Clients.Elasticsearch (ElasticsearchClient).
- Rework query building to use explicit BookQuery and Must / Should clauses (replaces
NEST's discontinued operator-composed queries).
2. JSON Serialization Migration (Newtonsoft.Json --> System.Text.Json)
- Replace NEST mapping attributes with JsonPropertyName.
3. Package & Project Updates
- Target framework corrected from netcoreapp8.0 to net8.0.
- NEST 7.9.* --> Elastic.Clients.Elasticsearch 8.19.12.
- NCI.OCPL.Api.Common updated from 3.0.1 to 4.0.0.
- Test packages updated (coverlet, Moq versions).
4. Infrastructure & Docker
- Elasticsearch Docker image updated from 7.17.28 to 8.19.12.
- Docker compose adds security-off settings (xpack.security.enabled=false) for local testing.
5. Test overhaul
- Test mocking migrated to TestingElasticsearchClientSettingsFactory to use the same
ElasticsearchClientSettings initialization as executable code.
- Refactor client mocking/construction.
6. Misc
Closes #78
blairlearn
force-pushed
the
ticket/78-es8
branch
from
02af708 to
ba99fbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch client migration
NEST's discontinued operator-composed queries).
JSON Serialization Migration (Newtonsoft.Json --> System.Text.Json)
Package & Project Updates
Infrastructure & Docker
Test overhaul
ElasticsearchClientSettings initialization as executable code.
Misc
Closes #78