(#67) Fix package distribution issues from integration review#68
Merged
adriancofie merged 1 commit intodevelopfrom Apr 27, 2026
Merged
(#67) Fix package distribution issues from integration review#68adriancofie merged 1 commit intodevelopfrom
adriancofie merged 1 commit intodevelopfrom
Conversation
Address findings from downstream integration of v0.1.0: - Subpath exports (./core, ./ncids): switch rollup to multi-entry input so the documented subpath bundles and matching .d.ts files are actually emitted. - Bundled stylesheet (./styles): the export now resolves to a real compiled CSS file (uswds-global, usa-pagination, usa-icon, usa-collection). README documents the import and the uswds-img sprite setup for Vite and Webpack consumers. - React peer raised to >=17.0.0. The build emits react/jsx-runtime, which only exists on React >=16.14, and React 16 has been EOL since 2024. - @nciocpl/ncids-css declared as an optional peer (>=3.0.0) so the existing peerDependenciesMeta.optional entry has effect. - Build hygiene: eliminate TS5069 declarationMap warning by overriding declarationMap:false alongside declaration:false in rollup-plugin- typescript options. Closes #67
Contributor
Storybook PreviewThis PR includes component changes. A Storybook build was verified successfully. Once merged, the updated Storybook will be deployed to GitHub Pages automatically. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./coreand./ncidssubpath exports (and matching.d.tsfiles) actually emit../stylesexport with a real compiled CSS bundle (USWDS global +usa-pagination,usa-icon,usa-collection) so consumers canimport '@nciocpl/react-components/styles'and get the styles the shipped components need.>=17.0.0(the build emitsreact/jsx-runtime, absent on React <16.14, and React 16 has been EOL since 2024) and declare@nciocpl/ncids-cssas the optional peer the existingpeerDependenciesMetawas already referencing.uswds-imgsprite.Background: these are findings from a downstream integration of v0.1.0 —
./coreand./ncidspointed at non-existent files,./stylesresolved to nothing useful, and consumers on React <16.14 hit a crypticCan't resolve 'react/jsx-runtime'error.Test plan
dist/:dist/{esm,cjs}/index.jsexistsdist/{esm,cjs}/components/{core,ncids}/index.jsexistdist/types/index.d.tsand per-subpath.d.tsexistdist/styles/index.csscontains rules forusa-paginationandusa-collectionimport { Pager } from '@nciocpl/react-components'import { Pager } from '@nciocpl/react-components/ncids'import '@nciocpl/react-components/styles'(withuswds-imgserved at/img)Closes #67