Repository navigation
Add 2025 menhaden data #88
Description
Description
Menhaden data is read in from a flat file and integrated into the creation of comdat landings. Instead of pulling menhaden from multiple sources, we need to pull from FOSS and integrate that data into the commercial landings and revenue workflow.
Justification
The menhaden file needs to be updated with 2025 data.
Activity
andybeet commentedon Aug 19, 2026
so if we get a reproducible way of pulling menhaden from the FOSS API, should we incorporate that directly into the
comlandrpackage with a function likeget_menhaden_data()similar to some of the other functions we have? might then avoid having a separate workflow in this repo. We'd then also have a stand alone function to pull menhaden, like we do herring and foreign data. What do you think?We could then document, in a vignette, a lot of what we just discussed (over chat) as part of the package
atyrell3 commentedon Aug 20, 2026
Yes, that sounds good to me!
atyrell3 commentedon Sep 17, 2026
I found some minimal documentation on how to query via url (not sure if this link will work), basically we can build the query from a base + parameters, ex:
https://apps-st.fisheries.noaa.gov/ods/foss/landings/?q={%22ts_afs_name%22:{%22$like%22:%22%MENHADEN%25%22},%22region_name%22:%22New%20England%22,%22year%22:2010}
However, I'm not sure if this data is exactly representative of what you would get from the manual data download. In the manual download, you can aggregate to region but the JSON seems to only have data at the state level. Due to confidentiality, I would expect that the regional data is different than the sum of its component states. I'm pretty sure I verified this in my previous data wrangling. So I'm not sure that the url download gets us what we need.
For this year, should we have the workflow run off of a manual data download from FOSS?
andybeet commentedon Sep 18, 2026
Yeah, i have access via the API all working. The issue is passing vectors. eg year = 2010,2011..., state=MA, CT, ME etc etc. I have been chatting with the project manager of FOSS and she doent know the correct syntax. She is meant to be chatting with the third party who helped develop this. i'll reach out again. Failing this, we might have to fall back on a GUI pull like you have already done
atyrell3 commentedon Oct 5, 2026
I reviewed the data from FOSS, ACCSP, and the state of VA. ACCSP and FOSS broadly match each other, but due to some missing data in ACCSP and recent lower catch reported in FOSS, we need to use:
Both of these data sources contain landing and revenue. Data are in
data-rawon thechore/i88-add-menhadenbranch, but ACCSP 2025 data is not yet complete.