Skip to content

Feat/update for nhf 1.2.2 - #100

Merged
dylanlee merged 6 commits into
mainfrom
feat/update-for-nhf_1.2.2
Jul 15, 2026
Merged

Feat/update for nhf 1.2.2#100
dylanlee merged 6 commits into
mainfrom
feat/update-for-nhf_1.2.2

Conversation

@dylanlee

Copy link
Copy Markdown

This PR:

  • Modifies the subsetter so that it returns the 3 new NHF 1.2.2 layers
  • Updates the hydrofabric schemas for the new layers and new divide attributes
  • Modifies build_nhf.py to make updating icefabric a bit more ergonomic. It also adds more info to the tools readme and tweaks the gpkg to parquet conversion script in tools.

@dylanlee
dylanlee requested a review from danielcumpton July 14, 2026 03:10
@danielcumpton

danielcumpton commented Jul 14, 2026

Copy link
Copy Markdown

nhf_gpkg_to_parquet in tools/hydrofabric/nhf_gpkg_to_parquet.py is missing the description for the new strict parameter.
Otherwise, I think the code looks good. I ran gage 06751150 which has two lakes and the new layers in addition to the existing lakes layer are there with data as expected.

@dylanlee
dylanlee merged commit 91660ef into main Jul 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants