Restart netCDF file on checkpoint restart (NGWPC-10459) - #222
Merged
idtodd merged 6 commits intoJul 22, 2026
Conversation
sivasankkar
approved these changes
Jul 20, 2026
sivasankkar
left a comment
There was a problem hiding this comment.
All changes are looking good. This can be merged.
|
After building with this branch, I ran two short range default forecasts for gage 01123000. For one of the forecasts, I interrupted the run after 3 time steps and restarted from a saved checkpoint. For the other forecast, I ran the full period continuously. I then compared differences across runs for both the catchment_output.nc and troute_output.nc files using the xarray xr.testing.assert_identical(x, y) function, which raises any differences between the passed files. Both the catchment_output.nc and troute_output.nc files were identical between continuous and restarted runs. This is good to merge on my end. |
idtodd
marked this pull request as ready for review
July 22, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
NetCDFManagerclass for opening and validating an existing netCDF file against expectations based on the realization configuration JSON.Removals
Changes
Layer::get_catchment_output_data_for_timestep()returns const reference to prevent copying potentially large data.NgenSimulationwill attempt to open an existing netCDF catchment file instead of creating a new one if checkpointing has been defined in the realization config JSON.Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support