Allow empty flow values in GPKG#4
Merged
Merged
Conversation
biplovbhandari
suggested changes
Jun 16, 2026
| ) | ||
| else: | ||
| logging.warning( | ||
| f"Skipping flow file validation as ignore_ras_flows is True. Received extension: {flow_file_extension} for submodel: {self.nwm_id}" |
Member
There was a problem hiding this comment.
Nit: can we fix the indentation under else: so logging.warning(...) is indented consistently?
Collaborator
There was a problem hiding this comment.
I've fixed this indention.
| f"Expected forcing extension to be .fxx, .uxx, or .qxx. Recieved {flow_file_extension} for submodel: {self.nwm_id}" | ||
| if not self.ignore_ras_flows: | ||
| raise ValueError( | ||
| f"Expected forcing extension to be .fxx, .uxx, or .qxx. Recieved {flow_file_extension} for submodel: {self.nwm_id}" |
Member
There was a problem hiding this comment.
typo: Recieved should be Received
mdeshotel
reviewed
Jun 16, 2026
mdeshotel
left a comment
mdeshotel
left a comment
Collaborator
There was a problem hiding this comment.
I added a TODO comment that I think would harden the code in the future. Probably 99% fine as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deals with the scenario that when an unsteady model that has been cleaned for unsteady geom objects want to be executed through Ripple1D, can do so despite having no flow information.
This is the case with
ohio_rfcmodel.