[GPCAPIM-260]-[Steel Thread integration testing]-[RP] #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BJSS-russell-pollock
changed the title
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-260-4
branch
3 times, most recently
from
20cf631 to
d6551d9
Compare
|
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-260-4
branch
16 times, most recently
from
cef02da to
278a4a7
Compare
BJSS-russell-pollock
changed the title
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-260-4
branch
3 times, most recently
from
803df79 to
926204f
Compare
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:feature-gpcapim-260-4
Findings (top 50)
|
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-260-4
branch
from
249af62 to
4c6e4d7
Compare
|
✅ Trivy gate: no Critical/High issues. Trivy IaC (Terraform) Summary
Findings (top 50)
|
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-260-4
branch
from
7745e16 to
4a4287d
Compare
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-260-4
branch
from
4a4287d to
6374e00
Compare
|
Deployment Complete
|
…ecord]-[RP] (#36) <!-- markdownlint-disable-next-line first-line-heading --> ## Description As a Tester I want to investigate and assess the GP Connect Demonstrator Get Patient Resource endpoint for potential use in the Steel Thread Get Patient Resource work. So that we can set up what we believe is the correct response body structure and enable a simple manual API test to support preparation. We are not proving anything at this stage. ## Context <!-- Why is this change required? What problem does it solve? --> GP Connect demonstrator has an existing endpoint that is capable of retrieving a FIHR STU3 patient resource by patient id https://orange.testlab.nhs.uk/ <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [ ] Refactoring (non-breaking change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have followed the code style of the project - [x] I have added tests to cover my changes - [x] I have updated the documentation accordingly - [] This PR is a result of pair or mob programming - [] Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request. --- ## Sensitive Information Declaration To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including [PII (Personal Identifiable Information) / PID (Personal Identifiable Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter. - [x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.
…arding them on to the controller/handler to process.
Creates the controller class that orchestrates calls to the other gateway components and to the GP provider. Integrates this with the API gateway, the PDS search module and the GP provider module. Updates integration-type tests to work with the steel thread.
By * concatingating the openapi and x-nhsd-apim yamls to for a template specification, * inserting the API variables/secrets into that template, * and using the Proxygen CLI tool within the preview-env workflow to deploy an instance defined by that specification.
BJSS-russell-pollock
force-pushed
the
feature/GPCAPIM-260-4
branch
from
55aaa1b to
7ea6cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.